-
Notifications
You must be signed in to change notification settings - Fork 527
Replace split_with_sizes_copy with slice_copy #10318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10318
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit a69ebbc with merge base cc3152b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D73312379 |
Summary: This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Differential Revision: D73312379
c3918b8
to
416edc8
Compare
This pull request was exported from Phabricator. Differential Revision: D73312379 |
Summary: Pull Request resolved: #10318 This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Differential Revision: D73312379
416edc8
to
e9f302e
Compare
Summary: This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Differential Revision: D73312379
e9f302e
to
342fea6
Compare
This pull request was exported from Phabricator. Differential Revision: D73312379 |
Summary: Pull Request resolved: #10318 This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Differential Revision: D73312379
342fea6
to
fb7f1cf
Compare
Summary: This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Reviewed By: zonglinpeng Differential Revision: D73312379
fb7f1cf
to
26d1b9f
Compare
This pull request was exported from Phabricator. Differential Revision: D73312379 |
Summary: This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Reviewed By: zonglinpeng Differential Revision: D73312379
26d1b9f
to
96bef6b
Compare
This pull request was exported from Phabricator. Differential Revision: D73312379 |
Summary: Pull Request resolved: #10318 This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Reviewed By: zonglinpeng Differential Revision: D73312379
96bef6b
to
316071a
Compare
Summary: This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Reviewed By: zonglinpeng Differential Revision: D73312379
316071a
to
22d4c88
Compare
Summary: Pull Request resolved: #10318 This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace `split_with_sizes`. That includes: - swapping with q/dq nodes to do it in lower bitwidth - becoming slice_nop when possible (through memory planning constraints) - a few simplification passes on slices - possibly finding patterns with slice/cat being a nop - we have an optimized slice op on HiFi already. We will get the split op soon to be fair, we can do some profiling then, but the above points will still stand Reviewed By: zonglinpeng Differential Revision: D73312379
This pull request was exported from Phabricator. Differential Revision: D73312379 |
22d4c88
to
a69ebbc
Compare
Summary:
This is useful for a few reasons, which are all related to the fact that we have a lot of things in place for slice ops, so the compiler can optimize much better if we replace
split_with_sizes
. That includes:Differential Revision: D73312379